[tor-bugs] #18943 [Core Tor/Tor]: sha3 testsuite fails on big endian hosts

[Tor Bug Tracker & Wiki]

#18943: sha3 testsuite fails on big endian hosts
------------------------------+------------------------------------
 Reporter:  weasel            |          Owner:  yawning
     Type:  defect            |         Status:  needs_review
 Priority:  High              |      Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor      |        Version:  Tor: 0.2.8.2-alpha
 Severity:  Major             |     Resolution:
 Keywords:  tor-core, crypto  |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------------
Changes (by yawning):

 * status:  assigned => needs_review


Comment:

 This *should* fix Big Endian targets.  Additionally while I'm here, the
 `xorin` call probably would have broken at a later date on ARM/PPC/etc
 when `src` isn't 8 byte aligned, so I addressed that as well (`dst` is
 fine assuming reasonable compiler behavior, the Keccak permutation code
 will also break if it's not properly aligned.).

 https://git.schwanenlied.me/yawning/tor/commit/e662e6c0983bfc6c5b4370b8c0c06a900bc508d7

 AFAIK the only code that calls this as of yet is the unit tests, and
 everyone else doing development that uses SHA3/SHAKE (the rng branch and
 the prop 224 people) haven't merged yet and use Intel systems anyway...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18943#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online