[tor-bugs] #18680 [Tor]: Don't declare the symbol "incoming queue" in every file including channel.h

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Mar 29 17:57:48 UTC 2016


#18680: Don't declare the symbol "incoming queue" in every file including channel.h
-------------------------+--------------------------------
     Reporter:  nickm    |      Owner:
         Type:  defect   |     Status:  new
     Priority:  Low      |  Milestone:  Tor: 0.2.9.x-final
    Component:  Tor      |    Version:
     Severity:  Trivial  |   Keywords:
Actual Points:           |  Parent ID:
       Points:  tiny     |   Reviewer:
      Sponsor:           |
-------------------------+--------------------------------
 According to nm, we have the symbol "incoming_queue" defined in all kinds
 of tor files.  Why?  Because of this line in channel.h:
 {{{
 TOR_SIMPLEQ_HEAD(chan_cell_queue, cell_queue_entry_s) incoming_queue;
 }}}

 Trivial fix in my branch incoming_queue_symbol_fix

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18680>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list