[tor-bugs] #18653 [Snowflake]: Copy-paste not working in snowflake client (global webrtcRemote is uninitialized)

[Tor Bug Tracker & Wiki]

#18653: Copy-paste not working in snowflake client (global webrtcRemote is
uninitialized)
---------------------------+-----------------
     Reporter:  dcf        |      Owner:
         Type:  defect     |     Status:  new
     Priority:  Medium     |  Milestone:
    Component:  Snowflake  |    Version:
     Severity:  Normal     |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |   Reviewer:
      Sponsor:             |
---------------------------+-----------------
 The copy-paste rendezvous doesn't work in [https://gitweb.torproject.org
 /pluggable-
 transports/snowflake.git/log/?id=6efb5cb8ef56bc84a56a8244f81a0817d7202912
 6efb5cb8]. The `readSignalingMessages` goroutine panics because the global
 `webrtcRemote` is `nil` at [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/client/snowflake.go?id=6efb5cb8ef56bc84a56a8244f81a0817d7202912#n142
 client/snowflake.go:142]:
 {{{
                 webrtcRemote.answerChannel <- sdp
 }}}

 `git bisect` says [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/commit/?id=b8815627bd189c3ee0829ce09152684726c6933c
 b8815627] "defer conn.Close for simplicity and remove unnecessary
 goroutines, improve error handling (close !#12)" is the first bad commit.

 I'm using the copy-paste rendezvous because I want to test a server
 locally for #18627.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18653>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online