[tor-bugs] #18625 [Tor]: Assertion conn->chosen_exit_name failed in circuit_is_acceptable at src/or/circuituse.c:119

[Tor Bug Tracker & Wiki]

#18625: Assertion conn->chosen_exit_name failed in circuit_is_acceptable at
src/or/circuituse.c:119
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Blocker                              |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc, regression,  |        Version:
  TorCoreTeam201603                              |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:                                       |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Code review:

 This all looks good. I am happy that it was merged.

 f590a303db: This correctly reverts the parts of e72cbf7a4e where I wrongly
 assumed that all anonymised connections used the ORPort. The parts dealing
 with ba6509e9 look ok, but I'd like dgoulet to review those.
 fbd79f38c2: yes, that check is now redundant...
 98abd49f6f: which makes this variable redundant
 8251fe5150: improves readability, doesn't change behaviour

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18625#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online