[tor-bugs] #18625 [Tor]: Assertion conn->chosen_exit_name failed in circuit_is_acceptable at src/or/circuituse.c:119

[Tor Bug Tracker & Wiki]

#18625: Assertion conn->chosen_exit_name failed in circuit_is_acceptable at
src/or/circuituse.c:119
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  High                                 |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Blocker                              |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc, regression,  |        Version:
  TorCoreTeam201603                              |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:                                       |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 f590a303db:

 {{{
 +    /* XXX the below line is suspicious and uncommented. does it close
 all
 +     * consensus fetches if we've already bootstrapped? investigate. */
      if (connection_dir_close_consensus_conn_if_extra(conn)) {
        return;
      }
 }}}

 I'll call this issue A1, split off into #18649.

 If we've bootstrapped, this line checks:
 * connection_dir_would_close_consensus_conn_helper which checks:
   * networkstatus_consensus_has_excess_connections which checks:
      * if there's more than one connection (including this connection)
 retrieving a consensus.
 * if there is, it closes the connection, if not, it leaves it alone.

 So it only closes this connection if there are other consensus connections
 already open.

 #18649 resolves this issue 18625.A1 by adding explanatory comments to this
 and related functions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18625#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online