[tor-bugs] #18623 [Tor]: DirPort reachability test fails preventing the relay to work properly

[Tor Bug Tracker & Wiki]

#18623: DirPort reachability test fails preventing the relay to work properly
-----------------------------------------------+---------------------------
 Reporter:  dgoulet                            |          Owner:
     Type:  defect                             |         Status:  new
 Priority:  Very High                          |      Milestone:  Tor:
Component:  Tor                                |  0.2.8.x-final
 Severity:  Blocker                            |        Version:  Tor:
 Keywords:  must-fix-before-028-rc regression  |  0.2.8.1-alpha
Parent ID:                                     |     Resolution:
 Reviewer:                                     |  Actual Points:
                                               |         Points:
                                               |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by dgoulet):

 This is what I have so far. After a bit more digging, this commit has an
 issue: `e72cbf7a4`

 In function `directory_initiate_command_rend()`, we only send the request
 to the DirPort if `or_connection` is 0 else we use the ORPort.
 {{{
 const int or_connection = use_begindir || anonymized_connection;
 }}}

 The problem is that the dir port test does use an anonymized connection
 (`DIRIND_ANON_DIRPORT`). I've made a patch that correctly sets the
 `or_connection` but it's still failing for some reason. (At least, I can
 see that we do test the right port.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18623#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online