[tor-bugs] #18351 [Tor]: Relay directory failures and logging are too aggressive

[Tor Bug Tracker & Wiki]

#18351: Relay directory failures and logging are too aggressive
------------------------------------------------+--------------------------
 Reporter:  sysrqb                              |          Owner:
     Type:  defect                              |         Status:
 Priority:  High                                |  needs_review
Component:  Tor                                 |      Milestone:  Tor:
 Severity:  Normal                              |  0.2.8.x-final
 Keywords:  regression, must-fix-before-028-rc  |        Version:  Tor:
Parent ID:                                      |  0.2.8.1-alpha
 Reviewer:                                      |     Resolution:
                                                |  Actual Points:
                                                |         Points:
                                                |        Sponsor:  None
------------------------------------------------+--------------------------
Changes (by teor):

 * status:  new => needs_review
 * version:  Tor: unspecified => Tor: 0.2.8.1-alpha


Comment:

 The log message from sysrqb in the ticket description didn't include the
 fix for #18348. I'm going to assume the underlying bug is fixed by #18348
 (or perhaps #18616). Let's release 0.2.8.2-alpha to find out.

 The log message from Christian in comment 5 did include the fix for
 #18348, but not the fix for #18616. It's unlikely that #18616 could fix
 this issue, because it's a different part of the code. I can't reproduce
 it with the latest master. Either it will be fixed in 0.2.8.2-alpha, or
 I'll need info-level logs to diagnose this issue.

 Until then, let's:
 * downgrade all these log messages to info-level
 * only log a backtrace once per tor launch
 * remove a backtrace where an IP version preference isn't satisfied

 Please see my branch bug18351 on https://github.com/teor2345/tor.git

 Let's close this issue when this branch is merged, and reopen another
 issue (ideally with info-level logs) if there are any problems in
 0.2.8.2-alpha.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18351#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online