[tor-bugs] #18604 [Tor]: Deleting an ephemeral service doesn't always destroy intro circuits

[Tor Bug Tracker & Wiki]

#18604: Deleting an ephemeral service doesn't always destroy intro circuits
-------------------------+--------------------
     Reporter:  special  |      Owner:
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:
    Component:  Tor      |    Version:
     Severity:  Normal   |   Keywords:  tor-hs
Actual Points:           |  Parent ID:
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+--------------------
 On tor 0.2.7.6 with hidden services configured via ADD_ONION, this warning
 appeared several times:

 {{{
     log_warn(LD_REND, "Unrecognized service ID %s on introduction circuit
 %u.",
              serviceid, (unsigned)circuit->base_.n_circ_id);
 }}}

 This happens when an introduction circuit finishes building and the
 service it was built for no longer exists.

 When removing an ephemeral service, we close all S_ESTABLISH_INTRO or
 S_INTRO circuits that are CIRCUIT_STATE_OPEN. I suspect this warning
 happens when the service is removed before an introduction circuit reaches
 STATE_OPEN.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18604>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online