[tor-bugs] #18600 [Tor]: Warning in rend_service_intro_has_opened isn't scrubbed

[Tor Bug Tracker & Wiki]

#18600: Warning in rend_service_intro_has_opened isn't scrubbed
-------------------------+-----------------
     Reporter:  special  |      Owner:
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:
    Component:  Tor      |    Version:
     Severity:  Minor    |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-----------------
 In rend_service_intro_has_opened, this warning:

 {{{
     log_warn(LD_REND, "Unrecognized service ID %s on introduction circuit
 %u.",
              serviceid, (unsigned)circuit->base_.n_circ_id);
 }}}

 Should use safe_str_client for the service ID. Even if it's unrecognized,
 it might be a service we used to offer, and the name shouldn't be logged.

 Patch to follow.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18600>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online