[tor-bugs] #18582 [Tor]: tor_addr_is_internal should never block PT dummy addresses

[Tor Bug Tracker & Wiki]

#18582: tor_addr_is_internal should never block PT dummy addresses
------------------------+--------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
    Component:  Tor     |    Version:  Tor: 0.2.7
     Severity:  Normal  |   Keywords:  comment-only easy
Actual Points:          |  Parent ID:
       Points:          |   Reviewer:
      Sponsor:          |
------------------------+--------------------------------
 In #17674 and #8976, we block internal addresses when opening a
 connection.

 In #18517, we chose 192.0.2.0/24 as a dummy address range for Tor Browser
 to use for pluggable transports to use when they don't have the actual
 remote address.

 Let's add a comment near the IPv4 range in tor_addr_is_internal_ to never
 block those addresses (or, if we do, to change how Tor Browser and PTs
 work first).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18582>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online