[tor-bugs] #18466 [Tor Browser]: Fix torbutton for ESR45

[Tor Bug Tracker & Wiki]

#18466: Fix torbutton for ESR45
---------------------------------------------+-----------------------------
 Reporter:  arthuredelstein                  |          Owner:  tbb-team
     Type:  defect                           |         Status:
 Priority:  Medium                           |  needs_review
Component:  Tor Browser                      |      Milestone:
 Severity:  Normal                           |        Version:
 Keywords:  TorBrowserTeam201603R, ff45-esr  |     Resolution:
Parent ID:  #15197                           |  Actual Points:
 Reviewer:                                   |         Points:
                                             |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by mcs):

 * cc: brade, mcs (added)


Comment:

 Kathy and I looked at c55c1ef497f7b2a97ff7c9b0af351a065df3b477 and
 594b2bbc55a0bbc2f548356f44ea191d4e2466e2. Your changes look good. We have
 two questions:
 Can you give us some background on why statements such as {{{let mozilla =
 mozilla || {};}}} were needed previously? Or maybe they were not needed?

 I assume that the newProxyInfoWithAuth() change is what breaks in ESR38.
 Can we avoid the need for a branch by using a runtime check such as:
 {{{if ("newProxyInfoWithAuth" in mozilla.protocolProxyService) ... }}} ?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18466#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online