[tor-bugs] #18371 [Tor Browser]: TorBrowser.app.meek-http-helper symlinks incompatible with Gatekeeper signing

[Tor Bug Tracker & Wiki]

#18371: TorBrowser.app.meek-http-helper symlinks incompatible with Gatekeeper
signing
-----------------------------------+------------------------------
 Reporter:  mcs                    |          Owner:  mcs
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201603R  |  Actual Points:
Parent ID:  #13252                 |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------

Comment (by dcf):

 Replying to [comment:15 mcs]:
 > Replying to [comment:14 dcf]:
 > > Tag [https://gitweb.torproject.org/pluggable-
 transports/meek.git/tag/?id=0.22-18371-2 0.22-18371-2] has the fixup
 patch.
 >
 > Thanks! It looks like we need to use a newer tag for goptlib as well. I
 see these error messages when I build:
 > {{{
 > ./meek-client.go:404: ptInfo.ProxyURL undefined (type pt.ClientInfo has
 no field or method ProxyURL)
 > ./meek-client.go:410: undefined: pt.ProxyError
 > ./meek-client.go:415: ptInfo.ProxyURL undefined (type pt.ClientInfo has
 no field or method ProxyURL)
 > ./meek-client.go:416: undefined: pt.ProxyDone
 > }}}
 >
 > Currently, Tor Browser defines GOPTLIB_TAG=0.2 and uses that when
 building meek.

 Yes, you will need `GOPTLIB_TAG=0.5` (the most recent tag) for the
 `ProxyURL` stuff.

 Alternatively, I could make you a branch off of 0.20, the current
 `MEEK_TAG` and the most recent one that doesn't depend on `ProxyURL` in
 goptlib.

 But the diffs are pretty minor:
   https://gitweb.torproject.org/pluggable-
 transports/goptlib.git/diff/?id=0.5&id2=0.2
   https://gitweb.torproject.org/pluggable-
 transports/meek.git/diff/?id=0.22&id2=0.20

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18371#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online