[tor-bugs] #18213 [Tor]: The parameter WarnUnsafeSocks does not work as specified in the documentation, no warning is logged in the log file

[Tor Bug Tracker & Wiki]

#18213: The parameter WarnUnsafeSocks does not work as specified in the
documentation, no warning is logged in the log file
-----------------------------------------------+---------------------------
 Reporter:  propropus                          |          Owner:
     Type:  defect                             |         Status:
 Priority:  High                               |  needs_information
Component:  Tor                                |      Milestone:  Tor:
 Severity:  Major                              |  0.2.8.x-final
 Keywords:  WarnUnsafeSocks, Log 027-backport  |        Version:
Parent ID:                                     |     Resolution:
 Reviewer:                                     |  Actual Points:
                                               |         Points:
                                               |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_information


Comment:

 We should srubbed() the port number here in the log.

 Also, I'm worried of a side effect on the user here.

 This adds a warning that could scare a user (maybe that's the whole
 point). I, for instance, often use IPs for my torsocks SSH and with this
 patch I'm getting quite a bit of warning in my notice log (even though
 it's rate limited) but still it's on purpose...

 Over days of using it, my notice log will be filled with those warnings
 which could 1) scare/confuse me and 2) add lots of noise and potentially
 miss other useful log statement.

 Are we worried about that? I am a bit to be honest... maybe it's just me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18213#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online