[tor-bugs] #18332 [Tor]: Relays should store HS descriptor without the complicated "am I the right one" logic

[Tor Bug Tracker & Wiki]

#18332: Relays should store HS descriptor without the complicated "am I the right
one" logic
--------------------------------------------+------------------------------
 Reporter:  dgoulet                         |          Owner:
     Type:  enhancement                     |         Status:
 Priority:  Medium                          |  needs_revision
Component:  Tor                             |      Milestone:  Tor:
 Severity:  Normal                          |  0.2.8.x-final
 Keywords:  tor-hs, must-fix-before-028-rc  |        Version:
Parent ID:                                  |     Resolution:
 Reviewer:                                  |  Actual Points:
                                            |         Points:  small
                                            |        Sponsor:  SponsorR
--------------------------------------------+------------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 The addition of this check in `rend_cache_store_v2_desc_as_dir()` broke
 some unit tests:
 {{{
 +  if (!public_server_mode(options)) {
 +    log_warn(LD_BUG, "rend_cache_store_v2_desc_as_dir() called but we're
 "
 +             "not a public relay. Refusing.");
 +    return -1;
    }
 }}}

 My branch `ticket18332_028_01` fixes that in a "questionable ugly way". We
 could remove that check actually since it's made in the
 `directory_handle_command_post` prior to ever calling the store function
 and it's the only code path that goes into it.

 It also broke that test and I don't know why:

 {{{
 routerlist/pick_directory_server_impl: [forking]
   FAIL src/test/test_routerlist.c:328:
 assert(tor_memeq(rs->identity_digest, router3_id, DIGEST_LEN))
   [pick_directory_server_impl FAILED]
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18332#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online