[tor-bugs] #18460 [Tor]: Relays and bridges are not counting directory requests coming in via IPv6

[Tor Bug Tracker & Wiki]

#18460: Relays and bridges are not counting directory requests coming in via IPv6
-------------------------------------------------+-------------------------
 Reporter:  karsten                              |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Tor                                  |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  tor-relay tor-bridge 026-backport    |        Version:  Tor:
  027-backport                                   |  0.2.8.1-alpha
Parent ID:                                       |     Resolution:
 Reviewer:                                       |  Actual Points:
                                                 |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 Replying to [comment:4 karsten]:
 > Replying to [comment:2 teor]:
 > > We should be careful that we are checking GeoIP for the remote
 address, rather than the address of any proxy. I think that 'address' is
 the remote address, and 'addr' is the proxy, at least in some places in
 the code.
 > >
 > > If that's the case, let's check and then update the comments on the
 struct definition, because I can never remember which way round it works.
 >
 > Oh, okay.  Any hints on where to start to find out?

 I would start by looking at everything that sets or modifies conn->address
 and conn->addr.

 One (painful but thorough) way to do that is to rename the field in the
 header, and look to see where all the errors appear.

 > Also, part of what makes me somewhat uncomfortable of using `address` is
 that it says "FQDN (or IP) of the other end" in the comment.  But we
 really want it to be an IP for `tor_inet_aton()`, or we're not counting it
 either.  When would `address` contain an FQDN instead of an IP?

 I can't think of a case where it would?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18460#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online