[tor-bugs] #13252 [Tor Browser]: Tor Browser on OS X should not store data into the application bundle

[Tor Bug Tracker & Wiki]

#13252: Tor Browser on OS X should not store data into the application bundle
-----------------------------------+------------------------------
 Reporter:  torosx                 |          Owner:  mcs
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201603R  |  Actual Points:
Parent ID:  #6540                  |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:30 gk]:
 > The tor-launcher changes look good to me. Some minor things:
 >
 > 1) regarding the changes in the prefs.js: s/tor_path pref./tor_path/
 like you did for the other paths?

 Sure. The comments are probably easier to read that way.

 > 2) I wonder whether
 > {{{
 > // In FF21+, CurProcD is the "browser" directory that is next to
 > // the firefox binary, e.g., <TorFileBaseDir>/Browser/browser
 > }}}
 > should be in the Tor Browser code path (as it basically was before). I
 was confused to read that comment and then the code continued to be
 concerned with Thunderbird/Instantbird

 You are right. We will move or remove that comment. We are already
 proposing that we move the check for FF >= 21:
   if (TorLauncherUtil.isAppVersionAtLeast("21.0"))

 > 3) What is the reason for treating `torrc-defaults` differently here,
 i.e. moving that one out of the data dir?

 The updater will not be able to touch anything inside TorBrowser-Data (at
 least that is our current plan). Therefore we need to put torrc-defaults
 somewhere inside the app bundle so it can be updated. Also, we do not
 really want users to edit torrc-defaults.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13252#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online