[tor-bugs] #13252 [Tor Browser]: Tor Browser on OS X should not store data into the application bundle

[Tor Bug Tracker & Wiki]

#13252: Tor Browser on OS X should not store data into the application bundle
-----------------------------------+------------------------------
 Reporter:  torosx                 |          Owner:  mcs
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:
Component:  Tor Browser            |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  TorBrowserTeam201603R  |  Actual Points:
Parent ID:  #6540                  |         Points:
  Sponsor:                         |
-----------------------------------+------------------------------

Comment (by gk):

 Okay, let's start with the easiest one: the Torbutton patch looks good to
 me. :)

 Comments to the tor-browser-bundle changes:

 1) It seems to me we can get rid of creating `Caches` altogether without
 the need for treating that step specially in the non-signed bundles? I
 tested it a bit and `Caches` seems to get created anyway.

 2) Could you add the FTE ticket number in the FTE TODO comment?

 3) The second `rm -rf $SKELETON_TMP` seems wrong to me as we are still in
 the directory we want to delete. And we already delete it before we begin
 with our skeleton preparation. Maybe a copy/paste fail?

 4) Do we have some alternative for handling the bookmarks file? Putting it
 into the `omni.ja` file seems a bit weird to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13252#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online