[tor-bugs] #18454 [Tor]: tor_addr_is_internal_(): Bug: tor_addr_is_internal() called from src/common/address.c:1668 with a non-IP address of type 11829

[Tor Bug Tracker & Wiki]

#18454: tor_addr_is_internal_(): Bug: tor_addr_is_internal() called from
src/common/address.c:1668 with a non-IP address of type 11829
-------------------------------+-------------------------------------
 Reporter:  toralf             |          Owner:
     Type:  defect             |         Status:  needs_review
 Priority:  Very High          |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                |        Version:  Tor: 0.2.3.11-alpha
 Severity:  Normal             |     Resolution:
 Keywords:  memory-corruption  |  Actual Points:
Parent ID:                     |         Points:
  Sponsor:                     |
-------------------------------+-------------------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * version:  Tor: 0.2.8.1-alpha => Tor: 0.2.3.11-alpha


Comment:

 Please see my branch bug18454 on https://github.com/teor2345/tor.git

 It includes both issues identified in the ticket in separate commits, and
 a single changes file.

 I chose to fix freeing an uninitialised ifc_buf by moving `ifc.ifc_buf =
 NULL;` higher in the function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18454#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online