[tor-bugs] #16917 [Tor Browser]: Support torified torsocks ssh -D socks proxy ports (for wingnuts)

[Tor Bug Tracker & Wiki]

#16917: Support torified torsocks ssh -D socks proxy ports (for wingnuts)
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
     Type:  enhancement                          |  cypherpunks
 Priority:  Medium                               |         Status:  closed
Component:  Tor Browser                          |      Milestone:
 Severity:  Normal                               |        Version:
 Keywords:  tbb-usability-stoppoint-wingnuts,    |     Resolution:  fixed
  TorBrowserTeam201603R                          |  Actual Points:
Parent ID:                                       |         Points:
  Sponsor:                                       |
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Okay, this looks good to me (and is commit
 06800f1c9c0a3c2adf850f9ad70e7ee8c3e645d0 now) with one execption:
 {{{
 let nontor_mode =
 m_tb_prefs.getBoolPref("extensions.torbutton.use_nontor_proxy");
 }}}
 is basically superfluous. I removed it in a fixup commit
 (8f40dd361efd3704a65ac8647f814f0415399da0). This will make it into 6.0a3.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16917#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online