[tor-bugs] #18462 [Tor]: Rename tor_dup_addr to make it clear that it returns a string

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Mar 2 16:19:29 UTC 2016


#18462: Rename tor_dup_addr to make it clear that it returns a string
-----------------------------+--------------------------------
     Reporter:  teor         |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  Medium       |  Milestone:  Tor: 0.2.9.x-final
    Component:  Tor          |    Version:
     Severity:  Normal       |   Keywords:  easy intro
Actual Points:               |  Parent ID:
       Points:               |    Sponsor:
-----------------------------+--------------------------------
 We discovered in #18454 that it's easy to write code that assumes that
 tor_dup_addr duplicates an address, rather than formatting that address as
 a string and duplicating that string.

 Let's change the name of that function to tor_addr_to_str_dup or
 something.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18462>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list