[tor-bugs] #18454 [Tor]: tor_addr_is_internal_(): Bug: tor_addr_is_internal() called from src/common/address.c:1668 with a non-IP address of type 11829

[Tor Bug Tracker & Wiki]

#18454: tor_addr_is_internal_(): Bug: tor_addr_is_internal() called from
src/common/address.c:1668 with a non-IP address of type 11829
-------------------------------+------------------------------------
 Reporter:  toralf             |          Owner:
     Type:  defect             |         Status:  new
 Priority:  Very High          |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal             |     Resolution:
 Keywords:  memory-corruption  |  Actual Points:
Parent ID:                     |         Points:
  Sponsor:                     |
-------------------------------+------------------------------------

Comment (by cypherpunks):

 {{{
    if (family == AF_INET || family == AF_UNSPEC) {
      if (get_interface_address6_via_udp_socket_hack(severity,AF_INET,
                                                     &addr) == 0) {
        if (include_internal || !tor_addr_is_internal(&addr, 0)) {
 -        smartlist_add(addrs, tor_dup_addr(&addr));
 +        smartlist_add(addrs, tor_memdup(&addr, sizeof(addr)));
        }
      }
    }

    if (family == AF_INET6 || family == AF_UNSPEC) {
      if (get_interface_address6_via_udp_socket_hack(severity,AF_INET6,
                                                     &addr) == 0) {
        if (include_internal || !tor_addr_is_internal(&addr, 0)) {
 -        smartlist_add(addrs, tor_dup_addr(&addr));
 +        smartlist_add(addrs, tor_memdup(&addr, sizeof(addr)));
        }
      }
    }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18454#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online