[tor-bugs] #19435 [Core Tor/Tor]: Negative number of suppressed messages

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jun 29 23:18:41 UTC 2016


#19435: Negative number of suppressed messages
--------------------------+------------------------------------
 Reporter:  twim          |          Owner:
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by twim):

 Replying to [comment:4 nickm]:
 > NAK on this patch: the point of the rate limiter is to avoid filling the
 log.  If we log up to one message per second, then we will still fill the
 log.

 Agreed. Shrinking the interval is more suitable for debugging than for
 logging. Anyway it does almost nothing to reduce amount of messages. :)

 > IMO a  better fix would be to set the rate limiter so that if it is
 INT_MAX, the count does not increment any more.

 I don't think that using INT_MAX is a good idea. It's way too large, we
 need to warn a user earlier. Sticking with RATELIM_TOOMANY for now, see
 the patch attached. Not sure if 16000 is big/small enough.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19435#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list