[tor-bugs] #19323 [Core Tor/Tor]: controller: expose Download timer/timeout/retry information

[Tor Bug Tracker & Wiki]

#19323: controller: expose Download timer/timeout/retry information
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  andrea
     Type:  enhancement                          |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-controller-extension             |        Version:
  TorCoreTeam201606                              |     Resolution:
Parent ID:  #17284                               |  Actual Points:  2
 Reviewer:                                       |         Points:  1
                                                 |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 * This needs a control-spec branch too
  * The documentation for digest_list_to_string() should say what the
 actual format is, if it's going to be exposed to the controller.  ("a
 sequence of newline-terminated hex-encoded digests"?)
  * Ditto "download_status_to_string".
  * For next time: getinfo_helper_downloads_cert and friends would be
 cleaner and easier to test if the "parse what they want" and the "get the
 cert corresponding to that they want" parts were separate functions.

 Otherwise looks good to me!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19323#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online