[tor-bugs] #18322 [Core Tor/Tor]: Log unparseable votes so they can be analysed

[Tor Bug Tracker & Wiki]

#18322: Log unparseable votes so they can be analysed
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-dos, TorCoreTeam201606, review-  |        Version:
  group-4                                        |     Resolution:
Parent ID:  #17293                               |  Actual Points:  3
 Reviewer:                                       |         Points:  2
                                                 |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------
Changes (by andrea):

 * status:  needs_revision => needs_review


Comment:

 See bug18322_v2 branch, which removes the fallback to the old-style
 logging, renames the config variable and checks for repeated identical
 unparseable descriptors when logging.  Current testing methodology is to
 run a private network and {{{curl --data-binary @test-desc.txt -v
 http://127.0.0.1:19030/tor/}}} with a suitably permuted bogus router
 descriptor in test-desc.txt and one dirauth's dirport at 127.0.0.1:19030.
 I'm working on some unit tests for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18322#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online