[tor-bugs] #19468 [Core Tor/Tor]: Revise prop259 to fit the Tor networking API

[Tor Bug Tracker & Wiki]

#19468: Revise prop259 to fit the Tor networking API
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  nickm
     Type:  defect                               |         Status:
 Priority:  Medium                               |  accepted
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-guard TorCoreTeam201606 prop259  |        Version:
Parent ID:  #12595                               |     Resolution:
 Reviewer:                                       |  Actual Points:
                                                 |         Points:  3
                                                 |        Sponsor:
                                                 |  SponsorU-must
-------------------------------------------------+-------------------------

Comment (by asn):

 Hello, I like the way this is going. Your version has various improvements
 in terms of engineering logic (e.g. the way primary guards work and the
 circuit states).

 [https://gitweb.torproject.org/user/asn/torspec.git/commit/?h=guard-
 proposal-nickm&id=e874136199250a833de3d831237c5cfcce0858dd I pushed an
 initial set of comments to my torspec repo].

 I mainly focused on the circuit states and guard list details. I still
 need to think more about this in terms of concurrent circuits, and how the
 'pending' flag works there.

 BTW, the thoughtworks team has written lots of code (and unittests) for
 this feature. It would be great if we could reuse some of that work, and
 not let it all go to waste. Fortunately, I feel that Nick's current
 version shares enough features with the thoughtworks version that we might
 be able to reuse stuff.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19468#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online