[tor-bugs] #19454 [Core Tor/Tor]: tor crashed when "HeartbeatPeriod 0"

[Tor Bug Tracker & Wiki]

#19454: tor crashed when "HeartbeatPeriod 0"
----------------------------+------------------------------------
 Reporter:  kukabu          |          Owner:
     Type:  defect          |         Status:  closed
 Priority:  Medium          |      Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor    |        Version:  Tor: 0.2.8.4-rc
 Severity:  Blocker         |     Resolution:  fixed
 Keywords:  review-group-4  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  asn             |        Sponsor:
----------------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:17 asn]:
 > Replying to [comment:15 cypherpunks]:
 > > FWIW the `PERIODIC_EVENT_NO_UPDATE` causes the callback function to be
 called every second if i understand the code of `periodic_event_dispatch`
 correctly.
 >
 > We think that's OK. One second is plenty of time for a computer, and
 that's how our code has been working for ages. Also see other functions
 that do the same thing (e.g. `write_bridge_ns_callback()`).
 >
 > Ideally we would have a better mechanism for scheduling timers, I agree.
 But we can do this in the future.
 >
 > Thx for feedback!
 I figured it was ok since it was reviewed. Just wanted to state it in case
 it was overlooked.

 I've opened #19476 with a patch that implements my interpretation of the
 `XXXX` comment from comment:4.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19454#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online