[tor-bugs] #19454 [Core Tor/Tor]: tor crashed when "HeartbeatPeriod 0"

[Tor Bug Tracker & Wiki]

#19454: tor crashed when "HeartbeatPeriod 0"
----------------------------+------------------------------------
 Reporter:  kukabu          |          Owner:
     Type:  defect          |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor    |        Version:  Tor: 0.2.8.4-rc
 Severity:  Blocker         |     Resolution:
 Keywords:  review-group-4  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  asn             |        Sponsor:
----------------------------+------------------------------------

Comment (by asn):

 Hello, please
 [https://gitweb.torproject.org/user/asn/tor.git/commit/?h=bug19454&id=9d17f9f0900764e591cf00cebd727449dbcdf730
 see branch bug19454 in my repo]:

 It's kind of based on cypherpunk's branch above, but it returns
 `PERIODIC_EVENT_NO_UPDATE` instead of defining a new magic number and
 returning that. I think that is more appropriate, but I'm not familiar
 with the callback system either. I also added a changes file and a
 function doc.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19454#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online