[tor-bugs] #18320 [Core Tor/Tor]: Clear old entries from the key-pinning journal file

[Tor Bug Tracker & Wiki]

#18320: Clear old entries from the key-pinning journal file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-dos, TorCoreTeam201606, review-  |        Version:
  group-3                                        |     Resolution:
Parent ID:  #17293                               |  Actual Points:
 Reviewer:  dgoulet                              |         Points:  3
                                                 |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 Replying to [comment:21 andrea]:
 > It ended up using HT_* because the existing keypin code used it; I can
 look at changing that if you like.

 Oh, I think that would be much better for both review and maintaining it
 in the long run. I do understand it's a bit of work though so I would say
 do it if you feel like it won't take you 2 days of work :). Else, we can
 create a new ticket about it and flag it "lorax" but I fear it will never
 be addressed... :S

 >
 > The double linked list is there because this table potentially has
 thousands of entries and smartlist_t is linear time to add/remove.  Not
 changing that.

 Very good point! Could we add this reason to the comment of the double
 linked list. Knowing why we use a certain type of data structure is
 _extremely_ useful (at least for my two-years-in-the-future self). Would
 be nice to see one day a linked list in the famous `container.h` :).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18320#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online