[tor-bugs] #19435 [Core Tor/Tor]: Negative number of suppressed messages

[Tor Bug Tracker & Wiki]

#19435: Negative number of suppressed messages
------------------------------+-----------------
     Reporter:  twim          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-----------------
 If one got too many messages in presumably enough (actually not) time
 interval an integer overflow can occur in rate-limiter. Thus one can
 observe negative or even *wrong* seems-to-be-ok number of suppressed
 messages.
 Example of such log message:
 {{{
 Failing because we have 991 connections already. Please read doc/TUNING
 for guidance.
 [-1237925175 similar message(s) suppressed in last 21600 seconds]
 }}}


 I've made a patch (see attachment) to address this issue by adjusting the
 rate if initial rate assumption is not valid anymore (plus boundary
 conditions handling). Thoughts?

 NB: I've made no test (yet) for this behavior.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19435>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online