[tor-bugs] #18875 [Metrics/metrics-lib]: Consider replacing RelayNetworkStatusVote's getDirectorySignatures() with getDirectorySignature()

[Tor Bug Tracker & Wiki]

#18875: Consider replacing RelayNetworkStatusVote's getDirectorySignatures() with
getDirectorySignature()
---------------------------------+------------------------------
 Reporter:  karsten              |          Owner:  karsten
     Type:  enhancement          |         Status:  needs_review
 Priority:  Medium               |      Milestone:
Component:  Metrics/metrics-lib  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:  #19398               |         Points:
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------

Comment (by karsten):

 Ah, I just pushed a fix that turns `"sha1"` into a constant and then re-
 read your comment.  What do you mean by public constant?  We don't yet
 know what other algorithms will be used in the future, and we shouldn't
 have to add a new constant whenever tor adds a new algorithm.  Or what did
 you mean?

 As always, thanks for the review!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18875#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online