[tor-bugs] #18280 [Core Tor/Tor]: base32 encoding API doesn't work for a source length that is not a multiple of 5 or 8

[Tor Bug Tracker & Wiki]

#18280: base32 encoding API doesn't work for a source length that is not a multiple
of 5 or 8
----------------------------+------------------------------------
 Reporter:  dgoulet         |          Owner:  dgoulet
     Type:  defect          |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  review-group-3  |  Actual Points:
Parent ID:  #18278          |         Points:  1
 Reviewer:  nickm           |        Sponsor:  SponsorR-can
----------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 NM1 has been addressed.
 NM2 has been detailed in the test how the values are generated.

 New branch: `bug18280_029_03`.

 It changes much more things. Among other things, `base32_encode()` does
 memory allocation to address the source length that can't be a multiple of
 5. I've added two helper functions which gets us closer to what the base64
 API looks like.

 I don't expect this to be the final version but it's something we can
 start from.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18280#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online