[tor-bugs] #19406 [Core Tor/Tor]: OpenSSL 1.1.0pre5 breaks with maint-0.2.8

[Tor Bug Tracker & Wiki]

#19406: OpenSSL 1.1.0pre5 breaks with maint-0.2.8
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  yawning
     Type:  defect                               |         Status:
 Priority:  High                                 |  assigned
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  TorCoreTeam201606 must-fix-          |        Version:
  before-028-rc                                  |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:                                       |         Points:  1
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Replying to [comment:3 yawning]:
 > https://git.schwanenlied.me/yawning/tor/src/bug19406 (against maint-028)
 >
 > This will never build cleanly against 1.1.0pre5 wiht -Werror (master is
 also broken):
 > {{{
 > In file included from
 /opt/openssl-1.1.0-pre5/include/openssl/x509.h:363:0,
 >                  from /opt/openssl-1.1.0-pre5/include/openssl/pem.h:65,
 >                  from ../src/tools/tor-gencert.c:17:
 > /opt/openssl-1.1.0-pre5/include/openssl/x509_vfy.h:379:6: warning:
 redundant redeclaration of ‘X509_STORE_CTX_set_verify_cb’ [-Wredundant-
 decls]
 >  void X509_STORE_CTX_set_verify_cb(X509_STORE_CTX *ctx,
 >       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
 > /opt/openssl-1.1.0-pre5/include/openssl/x509_vfy.h:312:6: note: previous
 declaration of ‘X509_STORE_CTX_set_verify_cb’ was here
 > }}}
 This is similar to the duplicate declaration of
 `SSL_get_selected_srtp_profile` which was fixed in OpenSSL commit
 [https://git.openssl.org/?p=openssl.git;a=commitdiff;h=3609b02305c3678525930ff9bacb566c0122ea2a
 3609b02305c3678525930ff9bacb566c0122ea2a]. `tortls.c` uses a `#pragma`
 dance (which has been replaced by a single preprocessor macro in master)
 to ignore this type of error and it seems `tor-gencert.c` now also needs
 it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19406#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online