[tor-bugs] #19380 [Core Tor/Tor]: Hand-audit compiler warning results which we wouldn't want to have on-by-default.

[Tor Bug Tracker & Wiki]

#19380: Hand-audit compiler warning results which we wouldn't want to have on-by-
default.
------------------------------+--------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.???
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  parent        |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 These warnings aren't definitely indicative of bugs in our code, and don't
 seem to be possible for us to fix in all cases.  Still, it might be worth
 auditing all the cases where these warnings trigger, since they _might_
 indicate bugs or possible areas of improvement.
 {{{
   strict-overflow=3...5 (4.2)

     Behaves pretty differently on different GCC versions.

     We get warnings for just about every case where we have pointer
     math in an addition. That seems nutty.

   padded (3)
     Not a mistake.  Worth looking over for hand-audit purposes, but mostly
     harmless.

   unsafe-loop-optimizations (4.1)
     Worth hand-auditing, but triggers on every kind of interesting for
 loop.

   covered-switch-default
     Usually this is defensive programming, but it could be a mistake
     in some cases, or could cover up future mistakes?
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19380>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online