[tor-bugs] #18320 [Core Tor/Tor]: Clear old entries from the key-pinning journal file

[Tor Bug Tracker & Wiki]

#18320: Clear old entries from the key-pinning journal file
----------------------------------------+----------------------------------
 Reporter:  teor                        |          Owner:  andrea
     Type:  defect                      |         Status:  assigned
 Priority:  Medium                      |      Milestone:  Tor:
Component:  Core Tor/Tor                |  0.2.9.x-final
 Severity:  Normal                      |        Version:
 Keywords:  tor-dos, TorCoreTeam201606  |     Resolution:
Parent ID:  #17293                      |  Actual Points:
 Reviewer:                              |         Points:  3
                                        |        Sponsor:  SponsorU-can
----------------------------------------+----------------------------------

Comment (by andrea):

 Observed in passing: the existing code here counts conflicts incorrectly;
 it only counts one conflicting line when a line conflicts with two
 previously seen keypin journal entries, even though it correctly removes
 two hash table entries in that case.  Will fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18320#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online