[tor-bugs] #19259 [Metrics/Onionoo]: uncaught NFE

[Tor Bug Tracker & Wiki]

#19259: uncaught NFE
-----------------------------+--------------------------
 Reporter:  iwakeh           |          Owner:  iwakeh
     Type:  defect           |         Status:  accepted
 Priority:  High             |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Major            |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------
Changes (by iwakeh):

 * status:  new => accepted
 * owner:   => iwakeh


Comment:

 Yes, tests first is the right approach. These will identify the places
 where the error is home-made due to the unspecified locale.

 I'll add all that to my todo-list.

 The nfe was not the reason I wanted the catch-clause, I just noticed that
 in addition.
 Try-with-resources is used in order to make sure that a resource is closed
 properly. Resources can fail b/c of many reasons (full disk, weird input,
 etc.) and we should at least log the failures there, as they might be
 important for operation or bug detection.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19259#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online