[tor-bugs] #19253 [Metrics/Onionoo]: replace submodule with released dependency of metrics-lib

[Tor Bug Tracker & Wiki]

#19253: replace submodule with released dependency of metrics-lib
-----------------------------+-----------------------------
 Reporter:  iwakeh           |          Owner:
     Type:  task             |         Status:  merge_ready
 Priority:  Low              |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Minor            |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------

Comment (by karsten):

 Thanks for reviewing!  Do you mind adding such a hint to the doc and
 trying out whether hamcrest-core is sufficient and possibly sending a
 patch?  Both changes sound useful to me.

 Also, I have been trying to run the .jar produced by the changed build
 file and ran into problems with metrics-lib formerly signed .jar.  Here's
 what I had to change after doing a quick search:

 {{{
 diff --git a/build.xml b/build.xml
 index c92fc3a..8e2c73c 100644
 --- a/build.xml
 +++ b/build.xml
 @@ -169,9 +169,16 @@
          <include name="logback-core-1.0.4.jar"/>
          <include name="slf4j-api-1.6.5.jar"/>
        </zipgroupfileset>
 -      <zipgroupfileset dir="lib">
 -        <include name="descriptor-1.2.0.jar"/>
 -      </zipgroupfileset>
 +      <restrict>
 +        <not>
 +          <name name="META-INF/*.SF" />
 +        </not>
 +        <archives>
 +          <zips>
 +            <fileset dir="lib" includes="descriptor-1.2.0.jar"/>
 +          </zips>
 +        </archives>
 +      </restrict>
        <fileset dir="${classes}"
                 excludes="org/torproject/onionoo/server/" />
        <fileset dir="${config}" includes="logback.xml" />
 }}}

 Is there a cleaner way to fix this?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19253#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online