[tor-bugs] #19212 [Applications/Tor Browser]: SIGSEGV on particular website with developer tools open

[Tor Bug Tracker & Wiki]

#19212: SIGSEGV on particular website with developer tools open
--------------------------------------+--------------------------
 Reporter:  cypherpunks               |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Very High                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  tbb-crash                 |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:14 mcs]:
 > On second thought, this may not be an exact duplicate of the Mozilla bug
 because of our dependency on the #16528 patch. But it sure is close.

 It is not. I applied both fixes but the issue remains. I still don't
 understand why `cx->compartment()` returns a null pointer with our patch
 applied. One way to handle that could be to do simply `return false` in
 this case, quick and dirty. I am not that happy about this solution
 though, as this introcuces a second order patch which might have issues on
 its own.

 Another way forward would be trying to understand why our patch is causing
 issues. I am still trying to wrap my head around the fact that basically
 just falling back to the PBM permission check is causing this. Why does
 commenting out those two code blocks cause our problem given that a normal
 Firefox in PBM does not care about those two code blocks either but does
 not crash anymore. (after bug 125835.

 A third approach might be to understand what role NoScript plays. Why is
 it causing `cx->compartment()` to be `null`. We could ask Giorgio if he'd
 merge a patch for us.

 I think I prefer option 2) right but time is up for now. I am back again
 in a couple of hours and I still have hope we can get that fixed in 6.0.1.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19212#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online