[tor-bugs] #19755 [Metrics/CollecTor]: improve code quality of bridgedescs module

[Tor Bug Tracker & Wiki]

#19755: improve code quality of bridgedescs module
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by iwakeh):

 I attached a patch simplifying the configuration setting.

 It would be good to create methods for the various list manipulations
 instead of the repeated loops over the descriptor line lists (i.e. more
 readable and shorter class file in total).

 And, some helper classes instead of private inner classes TarballBuilder
 and the different *DescriptorBuilders would make the test class a little
 shorter.

 I'm sort of wondering if the supply of the tests descriptor tars should be
 more direct? But that's a bigger change in this huge test class.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19755#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online