[tor-bugs] #19767 [Core Tor/Tor]: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump

[Tor Bug Tracker & Wiki]

#19767: Solaris, compile warning: "_FILE_OFFSET_BITS" redefined and core dump
----------------------------------------+----------------------------------
 Reporter:  RainerSchmidt               |          Owner:
     Type:  defect                      |         Status:  new
 Priority:  Medium                      |      Milestone:  Tor:
Component:  Core Tor/Tor                |  0.2.8.x-final
 Severity:  Major                       |        Version:  Tor: 0.2.8.5-rc
 Keywords:  Solaris, regression, crash  |     Resolution:
Parent ID:                              |  Actual Points:
 Reviewer:                              |         Points:  0.2
                                        |        Sponsor:
----------------------------------------+----------------------------------

Comment (by nickm):

 > I don't think we can break a platform.

 Well, it apparently isn't a platform that anybody tested 0.2.8 on at any
 time in the last 5 months. So I'm not sure it's a good idea to apply any
 patch here without a lot of testing, or to hold up the 0.2.8.6 release for
 all the platforms whose users _did_ test one of the alphas.

 That said, I've tried to fix up the warnings in a branch called
 "solaris_warnings_028" in my public git repository at
 https://git.torproject.org/nickm/tor.git .  If the file_offset_bits issue
 is causing the crash, I hope this will fix that.  Please review and test?

 I worry that these changes might break compilation on other platforms.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19767#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online