[tor-bugs] #19755 [Metrics/CollecTor]: improve code quality of bridgedescs module

[Tor Bug Tracker & Wiki]

#19755: improve code quality of bridgedescs module
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 Interesting reports!

 Regarding the tests, I picked up some of the suggestions you mentioned,
 but probably not all of them, and pushed
 [https://gitweb.torproject.org/karsten/metrics-db.git/log/?h=task-19755
 branch task-19755 to my public repository].

 Should we parallelize our efforts here?  For example, you could start
 fixing the reported bugs and refactor some code (while making sure you
 don't change the public interface that would break my tests) and I could
 write more tests (without touching code in `src/main/java/` that you're
 working on).

 If that's too complicated, either of us could also pause while the other
 moves forward.  Up to you!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19755#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online