[tor-bugs] #19163 [Core Tor/Tor]: Make sure clients almost always use ntor

[Tor Bug Tracker & Wiki]

#19163: Make sure clients almost always use ntor
---------------------------------------------+-----------------------------
 Reporter:  teor                             |          Owner:  teor
     Type:  defect                           |         Status:
 Priority:  Medium                           |  needs_review
Component:  Core Tor/Tor                     |      Milestone:  Tor:
 Severity:  Normal                           |  0.2.9.x-final
 Keywords:  rsos, tor-hs, TorCoreTeam201607  |        Version:
Parent ID:                                   |     Resolution:
 Reviewer:                                   |  Actual Points:  5
                                             |         Points:  1.0
                                             |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by teor):

 I added some fixups to reject-tap-v5 on both github and gitlab:

 d790fee fixup! Client & HS ignore UseNTorHandshake, all non-HS handshakes
 use ntor
 * Allow client intro and HS rend to use ntor, TAP, and CREATE_FAST, in
 that order

 5bc3335 fixup! Client intro opportunistically upgrades to ntor
 * Allow client intro to use TAP when none of the intro points are in the
 consensus
 * Allow Tor2web client intro to use CREATE_FAST when making a direct
 connection, none of the intro points are in the consensus, and none have
 TAP keys in the HS descriptor

 Gitlab is at:
 https://gitlab.com/teor/tor/merge_requests/2

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19163#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online