[tor-bugs] #19018 [Metrics/CollecTor]: run CollecTor modules without crontab
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jul 25 19:39:00 UTC 2016
#19018: run CollecTor modules without crontab
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: merge_ready
Priority: Medium | Milestone: CollecTor 1.0.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: ctip | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Changes (by iwakeh):
* status: needs_review => merge_ready
Comment:
Replying to [comment:14 karsten]:
> That branch looks good, I don't have any major requests for changes.
Please find [https://gitweb.torproject.org/karsten/metrics-
db.git/log/?h=task-19018 my branch task-19018] with two commits, one with
trivial whitespace fixes and one that fixes the properties template. Let
me know if you're okay with those changes.
Thanks for looking through quickly and correcting my whitespace quirks.
The added equal is fine in properties.
>
> And would you mind if we avoid that merge commit by going back to the
latest commit that is in master and your branch and cherry-picking
subsequent commits? I recognize that your branch is correct, but I
remember having trouble with merges in the past, so I'm trying to rebase
whenever I can. And with only two developers this still seems doable.
Happy to try this, and if the result is the same as your branch, except
for slightly changed commit history, I'd push to master. Sound okay?
Yes, that's ok, as long as all changes end up in master.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19018#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list