[tor-bugs] #19741 [- Select a component]: favicon in searchbar popup uses catchall circuit

[Tor Bug Tracker & Wiki]

#19741: favicon in searchbar popup uses catchall circuit
--------------------------------------+-----------------
     Reporter:  arthuredelstein       |      Owner:
         Type:  defect                |     Status:  new
     Priority:  Medium                |  Milestone:
    Component:  - Select a component  |    Version:
     Severity:  Normal                |   Keywords:
Actual Points:                        |  Parent ID:
       Points:                        |   Reviewer:
      Sponsor:                        |
--------------------------------------+-----------------
 To reproduce:

 * Set "torbutton.loglevel" to 3.
 * Enter the word "test" in the searchbar. Click on the DuckDuckGo icon in
 the popup menu below to cause a search for "test" to be performed on
 DuckDuckGo. After the search is performed, a green "plus" symbol appears
 on the searchbar magnifying glass icon.
 * Open the browser console, and clear it.
 * Click on the searchbar again. An additional menu item appears, which
 contains the text `Add "DuckDuckGo (HTML)"` and a DuckDuckGo favicon.
 * Examine the browser console. Log messages should appear as follows:
 {{{
 [07-22 22:38:01] Torbutton INFO: tor SOCKS:
 http://3g2upl4pq6kufc4m.onion/favicon.ico via --NoFirstPartyHost-chrome-
 browser.xul--:9bb8a61534faf1f952647a3537560fb0
 GET
 http://3g2upl4pq6kufc4m.onion/favicon.ico [HTTP/1.1 200 OK 0ms]
 getFirstPartyURI failed for chrome://browser/content/browser.xul:
 0x80070057
 [07-22 22:38:02] Torbutton INFO: controlPort >> 650 STREAM 264 NEW 0
 3g2upl4pq6kufc4m.onion:80 SOURCE_ADDR=127.0.0.1:52895 PURPOSE=USER
 [07-22 22:38:02] Torbutton INFO: controlPort >> 650 STREAM 264 SENTCONNECT
 15 3g2upl4pq6kufc4m.onion:80
 getFirstPartyURI failed for chrome://browser/content/browser.xul:
 0x80070057
 [07-22 22:38:02] Torbutton INFO: controlPort >> 650 STREAM 264 SUCCEEDED
 15 3g2upl4pq6kufc4m.onion:80
 }}}
   should be visible. I believe these messages are caused by

 So it appears that the favicon display inside "add-engines" vbox of the
 search popup is being sent over the catchall circuit.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19741>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online