[tor-bugs] #8625 [Core Tor/Tor]: Do not call networkstatus_reset_download_failures() hourly

[Tor Bug Tracker & Wiki]

#8625: Do not call networkstatus_reset_download_failures() hourly
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  andrea
     Type:  defect                               |         Status:
 Priority:  High                                 |  assigned
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-client 025-backport              |        Version:
  026-triaged-1 026-deferrable tor-dos           |     Resolution:
  TorCoreTeam201607                              |  Actual Points:
Parent ID:                                       |         Points:  3
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU-can
-------------------------------------------------+-------------------------

Comment (by andrea):

 The {{{if (!options->FetchServerDescriptors)}}} test in
 {{{directory_get_from_dirserver()}}} looks promising, but doesn't actually
 do the thing we need because it prevents new requests from being launched
 too early for {{{download_status_increment_failure()}}} to ever be called.
 I'm adding a new {{{SimulateDirDownloadFailures}}} config boolean for
 this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8625#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online