[tor-bugs] #19273 [Applications/Tor Browser]: Write C++ patch to replace external applications helper dialog workaround

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jul 18 14:49:00 UTC 2016


#19273: Write C++ patch to replace external applications helper dialog workaround
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  mcs
     Type:  task                                 |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  TorBrowserTeam201607R, tbb-          |  Actual Points:
  usability, tbb-torbutton-conversion            |         Points:
Parent ID:                                       |        Sponsor:
 Reviewer:                                       |  SponsorU
-------------------------------------------------+-------------------------

Comment (by brade):

 Replying to [comment:9 gk]:
 > Okay, finally. Looks good to me and I am happy to see my crazy
 workaround going. I made a fixup commit removing the remaining bits from
 my #9901 patch we don't need anymore
 (7dd710152955bd4145814c8bafed3b50dfacff75 on torbutton master). mcs' and
 brade's patches are commit 6d5dc7845579ca99d9c46d921876e477ba60935f on
 torbutton master and commit 4b7123f235465f26052ea0dfaeebb590a3f31e0f on
 tor-browser-45.2.0esr-6.5-1.

 Thanks for your review and for catching what we missed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19273#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list