[tor-bugs] #19615 [Metrics/CollecTor]: CollecTor should confirm to style guide

[Tor Bug Tracker & Wiki]

#19615: CollecTor should confirm to style guide
-------------------------------+-----------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  task               |         Status:  merge_ready
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:  #19611             |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+-----------------------------
Changes (by iwakeh):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:3 karsten]:
 > Reviewed, please look at [https://gitweb.torproject.org/karsten/metrics-
 db.git/log/?h=task-19615 my branch task-19615] with the following
 additional commits:
 >  - 03eb6c3 documents the change to the checkstyle file, which looks like
 a useful change to me.
 >  - 19ce99c makes some trivial whitespace fixes.
 >  - 9857cf0 replaces all suppressed Javadoc warnings with actual
 Javadocs.  There were only 25 of them, so I figured we could rather fix
 those issues for real rather than just covering them.  I might have
 decided differently if there had been 250.
 >  - ac038af cleans up imports a bit, so that Eclipse looks less yellow
 here.
 All fine.  Thanks for adding the Javadoc!

 >
 > While writing these Javadocs, I found a few issues in recently added
 code which I didn't fix yet:
 >  - `CreateIndexJson.main()` creates three `File` instances with
 configuration values as directory name and a still hard-coded string as
 file name.  Should we remove the hard-coded strings to keep overall paths
 unchanged from before that change?
 Added to #19424.

 >  - It seems that `collector.properties` uses different paths for
 formerly hard-coded paths as new defaults.  Ideally, defaults should be
 exactly the same as before.  Should we change defaults back?
 >
 I'll add this to #19424, too.  It makes sense to have the defaults set as
 the main instance CollecTor uses them.
 > If you like my changes, I'll squash and push to master.  The latter
 issues should go into a new ticket.
 Ready for merge and open tasks added to other ticket.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19615#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online