[tor-bugs] #19665 [Core Tor/Tor]: Should *Port_set count sockets?

[Tor Bug Tracker & Wiki]

#19665: Should *Port_set count sockets?
------------------------------+--------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.???
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  030-proposed
Actual Points:                |  Parent ID:
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 In parse_ports in 0.2.8-stable and earlier, we didn't count sockets as
 listeners when setting options->*Port_set.

 This makes sense for server ports, is confusing for
 ControlPort/ControlSocket (because you can set a control socket using the
 ControlPort option, can't you?), and didn't matter for client ports,
 because those values were never used.

 In #17178 I modified the client port options to count sockets.
 But we should definitely review the control port situation some time.
 I don't think it's serious, because the current code warns on ControlPorts
 and ControlSockets.
 But it makes it easy to introduce subtle bugs.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19665>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online