[tor-bugs] #19273 [Applications/Tor Browser]: Write C++ patch to replace external applications helper dialog workaround

[Tor Bug Tracker & Wiki]

#19273: Write C++ patch to replace external applications helper dialog workaround
--------------------------------------+------------------------------
 Reporter:  gk                        |          Owner:  mcs
     Type:  task                      |         Status:  needs_review
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201607R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:  SponsorU
--------------------------------------+------------------------------

Comment (by mcs):

 Replying to [comment:7 arthuredelstein]:
 > I have looked over the code and I think it looks good. (I am still
 building it and will report if I see any problems.)

 Thanks for looking at the code.

 > General question: do you think a fix for
 https://bugzilla.mozilla.org/show_bug.cgi?id=440892 would use this
 observer mechanism? Or could a proper check for "network.protocol-handler
 .warn-external" be simply built directly into the code? I'm wondering what
 the right approach would be for future upstreaming.

 I think a proper fix should just be built into the code (probably inside
 uriloader/exthandler/nsHandlerService.js). But given the uncertainty that
 was expressed by mikeperry in the following comment, Kathy and I thought
 it would be best to mimic the existing hooks that were in Torbutton
 (replacing the component overrides with an observer notification):
 https://trac.torproject.org/projects/tor/ticket/9901#comment:74

 Also, if we want to include a custom message it is easier to have our own
 separate dialog (although we did experiment with using a XUL overlay; see
 ticket:16623#comment:3).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19273#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online