[tor-bugs] #19570 [Core Tor/Tor]: Shared random round gets out of sync

[Tor Bug Tracker & Wiki]

#19570: Shared random round gets out of sync
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  needs_information
 Priority:  High          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sr        |  Actual Points:
Parent ID:                |         Points:  0.5
 Reviewer:                |        Sponsor:  SponsorR-must
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  new => needs_information


Comment:

 Replying to [ticket:19570 teor]:
 > I started this test directory authority at 00:54:30 UTC
 > (Log times UTC+10)
 > `Jul 05 12:00:01.000 [info] sr_state_update(): SR: State prepared for
 upcoming voting period (2016-07-05 03:00:00). Upcoming phase is commit
 (counters: 3 commit & 0 reveal rounds).`

 This one is worrying to me because there is suppose to be a gap of *one
 hour* (or 30 minutes) between the log time `12:00:01` and the upcoming
 voting period which here is `03:00:00`.

 The upcoming time we see is taken from the
 `voting_schedule_t->interval_starts`.

 We use `get_voting_schedule()` for this and we log it at NOTICE level so
 you should have a bit before that log message this that should help us:

 {{{
     format_iso_time(tbuf, new_voting_schedule->interval_starts);
     tor_log(severity, LD_DIR,"Choosing expected valid-after time as %s: "
             "consensus_set=%d, interval=%d",
             tbuf, consensus?1:0, interval);
 }}}

 I would probably speculate towards a voting schedule bug here since we
 really don't do any modification on that voting interval. The phases
 completely follows the voting schedule.

 Attaching logs to this ticket would be useful also.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19570#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online