[tor-bugs] #19567 [Core Tor/Tor]: SR: Fix issues Coverity found:

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jul 5 15:04:51 UTC 2016


#19567: SR: Fix issues Coverity found:
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:
     Type:  defect        |         Status:  merge_ready
 Priority:  High          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sr test   |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:                |        Sponsor:  SponsorR-must
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Right the reason `*next = NULL` is there is to make sure that the "config"
 option is reset to empty if any error happens. In our case, we have the
 disk state reset prior that makes sure everything is NULLed out so we do
 not need that line.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19567#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list